Link to issues in mypy.ini for non py.typed dependencies #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Aug 12, 2024
mypy.ini
Outdated
| # - All jaraco modules are still untyped | ||
| # - _validate_project sometimes complains about trove_classifiers (#4296) | ||
| # - wheel appears to be untyped | ||
| [mypy-distutils._modified,jaraco.*,trove_classifiers,wheel.*] |
There was a problem hiding this comment.
trove_classifiers being flagged as a missing install was a symptom of the issue linked below python/mypy#11936 (comment) that is better (and already) worked around with the configuration below
Avasam
force-pushed
the
Link-to-issues-in-mypy.ini-for-non-py.typed-dependencies
branch
from
ddf3ff0
to
4a4fac2
Compare
Avasam
commented
Aug 12, 2024
| # - _validate_project sometimes complains about trove_classifiers (#4296) | ||
| # - wheel appears to be untyped | ||
| [mypy-distutils._modified,jaraco.*,trove_classifiers,wheel.*] | ||
| # - The following are not marked as py.typed: |
There was a problem hiding this comment.
Comment for cross-linking:
- jaraco.develop: Fully type module then mark as
py.typedjaraco/jaraco.develop#22 - jaraco.envs: Fully type module then mark as
py.typedjaraco/jaraco.envs#7 - jaraco.packaging: Fully type module then mark as
py.typedjaraco/jaraco.packaging#20 - jaraco.path: Fully type module then mark as
py.typedjaraco/jaraco.path#2 - jaraco.test: Fully type module then mark as
py.typedjaraco/jaraco.test#7 - jaraco.text: Fully type module then mark as
py.typedjaraco/jaraco.text#17 - wheel: does not intend on exposing a programatic API General typing improvement wheel#610 (comment)
Avasam
force-pushed
the
Link-to-issues-in-mypy.ini-for-non-py.typed-dependencies
branch
from
4a4fac2
to
0c4df19
Compare
Avasam
force-pushed
the
Link-to-issues-in-mypy.ini-for-non-py.typed-dependencies
branch
3 times, most recently
from
6cfba7a
to
c9adf2e
Compare
Avasam
force-pushed
the
Link-to-issues-in-mypy.ini-for-non-py.typed-dependencies
branch
from
c9adf2e
to
6081e1d
Compare
|
Thank you! |
Avasam
deleted the
Link-to-issues-in-mypy.ini-for-non-py.typed-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As requested here: jaraco/skeleton#136 (comment)
Pull Request Checklist
newsfragments/. (not user facing)(See documentation for details)